feat(showcase): add conditional rendering for login page #602
Conversation
🦋 Changeset detectedLatest commit: 80d6a79 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tried testing it with gitlab and got the following error: It appears we also need to configure the auth provider integrations in the https://backstage.io/docs/auth/identity-resolver/ Managed to login with gitlab once I configured the auth provider for gitlab. providerFactories: {
...defaultAuthProviderFactories,
gitlab: providers.gitlab.create({
signIn: {
async resolver({ result: { fullProfile } }, ctx) {
const userId = fullProfile.username;
if (!userId) {
throw new Error(
`GitLab user profile does not contain a username`,
);
}
// Creates an entity
const userEntity = stringifyEntityRef({
kind: 'User',
name: userId,
namespace: DEFAULT_NAMESPACE,
});
const { entity } = await ctx.findCatalogUser({
entityRef: userEntity,
});
const ownership = getDefaultOwnershipEntityRefs(entity);
return ctx.issueToken({
claims: {
sub: userEntity,
ent: ownership,
},
});
},
},
}),
... |
@Zaperex this PR does not cover the entity mapping so this is to be expected. |
Signed-off-by: Paul Schultz <pschultz@pobox.com>
schultzp2020
force-pushed
the
conditional-login-page
branch
from
5db79bd
to
2f81cce
Compare
Signed-off-by: Paul Schultz <pschultz@pobox.com>
…into conditional-login-page
Signed-off-by: Paul Schultz <pschultz@pobox.com>
|
The image is available at: |
…into conditional-login-page
Signed-off-by: Paul Schultz <pschultz@pobox.com>
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
|
Blocked by backstage/backstage#20877 |
…into conditional-login-page Signed-off-by: Paul Schultz <pschultz@pobox.com>
…/backstage-showcase into conditional-login-page
|
The image is available at: |
|
The image is available at: |
Signed-off-by: Paul Schultz <pschultz@pobox.com>
|
The image is available at: |
|
The image is available at: |
Signed-off-by: Paul Schultz <pschultz@pobox.com>
|
The image is available at: |
|
The image is available at: |
| - OneLogin - `onelogin` | ||
| - SAML - `saml` | ||
|
|
||
| - Add the corresponding authentication provider key as the value to `signInPage` in your `app-config`. |
There was a problem hiding this comment.
Should we include something along the lines of 'To disabled the Guest login set auth.environment to production'?
There was a problem hiding this comment.
this brings me to the question, what if someone wants to enable guest in production environment? Is that possible?
Yeah I was debating the same thing. My conclusion was that companies typically only have one sign in option, if this is not the case we can easily change this. However, there is an issue where the proxy sign in can only have ONE option. I have also yet to find a case where logging in is not required for a company. |
…into conditional-login-page
Signed-off-by: Paul Schultz <pschultz@pobox.com>
|
The image is available at: |
|
Kudos, SonarCloud Quality Gate passed!
|
|
The image is available at: |
Description
Please explain the changes you made here.
Which issue(s) does this PR fix
ConfigReaderincorrectly readsfallbackbackstage/backstage#20877PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer