feat(dynamic-plugins): replace static MUI Icons library import with dynamic appIcons #736
Conversation
🦋 Changeset detectedLatest commit: 361aa8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The image is available at: |
tumido
force-pushed
the
make-icons-dynamic
branch
from
574ac5b
to
ecf07cb
Compare
|
The image is available at: |
|
|
tumido
force-pushed
the
make-icons-dynamic
branch
from
ecf07cb
to
7e1ed29
Compare
…ynamic appIcons Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
tumido
force-pushed
the
make-icons-dynamic
branch
from
7e1ed29
to
d60e5ff
Compare
tumido
added
the
cherry-pick-1.0.x
|
The image is available at: |
|
Of course after I approved I realized I was on the wrong branch. Should this icon no longer be showing up with this change in place:
|
|
Ah, sorry for the noise that's behaving as expected, I of course had it mis-configured locally :-) |
|
Kudos, SonarCloud Quality Gate passed!
|
|
The image is available at: |
kadel
added
the
cherry-pick-OK
…ynamic appIcons (janus-idp#736) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Co-authored-by: Tomas Kral <tkral@redhat.com>
Description
Instead of embedding all MUI4 icons into the bundle, we can depend in
app.getSystemIcon()icon catalog. This PR allows users to extend it via dynamic plugins and therefore cleanup our bundle of unnecessary icons.Which issue(s) does this PR fix
Depends on: janus-idp/backstage-plugins#919Resolves: #725
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer