Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json): fix test script #739

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix(package.json): fix test script #739

merged 1 commit into from
Nov 8, 2023

Conversation

schultzp2020
Copy link
Member

Description

Adds --passWithNoTests to the test script.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Signed-off-by: Paul Schultz <pschultz@pobox.com>
@schultzp2020 schultzp2020 requested a review from a team as a code owner November 8, 2023 16:17
Copy link

changeset-bot bot commented Nov 8, 2023

⚠️ No Changeset found

Latest commit: 02110cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@schultzp2020 schultzp2020 merged commit 7ed4465 into main Nov 8, 2023
5 of 6 checks passed
@schultzp2020 schultzp2020 deleted the fix-test-script branch November 8, 2023 16:46
Copy link
Contributor

github-actions bot commented Nov 8, 2023

The image is available at: quay.io/janus-idp/backstage-showcase:pr-739!

reavessm pushed a commit to RedHatInsights/backstage-showcase that referenced this pull request Nov 8, 2023
Signed-off-by: Paul Schultz <pschultz@pobox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants