Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dynamic-plugins): update and complete the docs #752

Merged
merged 23 commits into from
Nov 10, 2023

Conversation

davidfestal
Copy link
Member

Description

Update and complete the dynamic-plugins docs.

Which issue(s) does this PR fix

No issue

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@davidfestal davidfestal requested a review from a team as a code owner November 9, 2023 20:05
Copy link

changeset-bot bot commented Nov 9, 2023

🦋 Changeset detected

Latest commit: 0a439e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davidfestal davidfestal changed the title docs(dynamic-plugins): Update and complete the docs docs(dynamic-plugins): update and complete the docs Nov 9, 2023
@davidfestal davidfestal added the cherry-pick-1.0.x This PR should be cherry-picked to the 1.0.x branch label Nov 9, 2023
Signed-off-by: David Festal <dfestal@redhat.com>
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
davidfestal and others added 10 commits November 9, 2023 21:49
Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>
Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>
Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>
Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>
Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>
Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>
Co-authored-by: Paul Schultz <pschultz@pobox.com>
Co-authored-by: Paul Schultz <pschultz@pobox.com>
Co-authored-by: Paul Schultz <pschultz@pobox.com>
Co-authored-by: Paul Schultz <pschultz@pobox.com>
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
davidfestal and others added 7 commits November 9, 2023 22:14
Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>
Co-authored-by: Paul Schultz <pschultz@pobox.com>
Co-authored-by: Paul Schultz <pschultz@pobox.com>
Co-authored-by: Paul Schultz <pschultz@pobox.com>
Co-authored-by: Paul Schultz <pschultz@pobox.com>
Co-authored-by: Paul Schultz <pschultz@pobox.com>
Co-authored-by: Paul Schultz <pschultz@pobox.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Copy link
Member

@Zaperex Zaperex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Paul Schultz <pschultz@pobox.com>
Copy link
Member

@invincibleJai invincibleJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
Co-authored-by: Jaivardhan Kumar <mailjai.vardhan@gmail.com>
@davidfestal
Copy link
Member Author

/test

Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kadel kadel merged commit 183f894 into janus-idp:main Nov 10, 2023
3 checks passed
kadel pushed a commit to kadel/backstage-showcase that referenced this pull request Nov 10, 2023
* docs(dynamic-plugins): Update and complete.

Signed-off-by: David Festal <dfestal@redhat.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Paul Schultz <pschultz@pobox.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Paul Schultz <pschultz@pobox.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Paul Schultz <pschultz@pobox.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Paul Schultz <pschultz@pobox.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Paul Schultz <pschultz@pobox.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Paul Schultz <pschultz@pobox.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Paul Schultz <pschultz@pobox.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Paul Schultz <pschultz@pobox.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Paul Schultz <pschultz@pobox.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Paul Schultz <pschultz@pobox.com>

* Drop the warning, which doesn't make sense anymore

Signed-off-by: David Festal <dfestal@redhat.com>

* Small path fix

Signed-off-by: David Festal <dfestal@redhat.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Paul Schultz <pschultz@pobox.com>

* Update showcase-docs/dynamic-plugins.md

Co-authored-by: Jaivardhan Kumar <mailjai.vardhan@gmail.com>

* Create perfect-balloons-repeat.md

---------

Signed-off-by: David Festal <dfestal@redhat.com>
Co-authored-by: Frank Kong <50030060+Zaperex@users.noreply.github.com>
Co-authored-by: Paul Schultz <pschultz@pobox.com>
Co-authored-by: Jaivardhan Kumar <mailjai.vardhan@gmail.com>
@kadel kadel added the cherry-pick-OK This PR was successfully cherry-picked to the appropriate branch. label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-1.0.x This PR should be cherry-picked to the 1.0.x branch cherry-pick-OK This PR was successfully cherry-picked to the appropriate branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants