Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching the Showcase to the new backend system & 1.23.0-next.3 pre-release #897

Merged

Conversation

davidfestal
Copy link
Member

@davidfestal davidfestal commented Jan 23, 2024

Description

This PR is a proof PR of everything involved in switching the Showcase application to the new backend system, and bumping it at the same time to the 1.23.0-next.3 pre-release, in order to prepare for the adoption of the upcoming 1.23.0 release.

Which issue(s) does this PR fix

This PR is related to EPIC #834

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@davidfestal davidfestal requested a review from a team as a code owner January 23, 2024 12:33
Copy link

changeset-bot bot commented Jan 23, 2024

🦋 Changeset detected

Latest commit: 60eb74d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
backstage-plugin-scaffolder-backend-module-gitlab Patch
backstage-plugin-scaffolder-backend-module-github Patch
backstage-plugin-scaffolder-backend-module-azure Patch
backstage-plugin-scaffolder-backend-module-gerrit Patch
backstage-plugin-scaffolder-backend-module-bitbucket-cloud Patch
backstage-plugin-scaffolder-backend-module-bitbucket-server Patch
backstage-plugin-catalog-backend-module-github-org Patch
immobiliarelabs-backstage-plugin-gitlab-backend Patch
backstage-plugin-catalog-backend-module-github Patch
backstage-plugin-catalog-backend-module-gitlab Patch
roadiehq-backstage-plugin-argo-cd-backend Patch
roadiehq-scaffolder-backend-module-utils Patch
backstage-plugin-azure-devops-backend Patch
backstage-plugin-kubernetes-backend Patch
backstage-plugin-sonarqube-backend Patch
roadiehq-scaffolder-backend-argocd Patch
backstage-plugin-techdocs-backend Patch
backstage-plugin-jenkins-backend Patch
@internal/plugin-dynamic-plugins-info-backend Patch
@internal/plugin-scalprum-backend Patch
backend Patch
dynamic-plugins-imports Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-897!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-897!

Copy link

janus-idp bot commented Jan 23, 2024

backstage-showcase Tests on commit f02beb8 finished with errors.
View test log

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-897!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-897!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-897!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-897!

Copy link
Contributor

github-actions bot commented Feb 1, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-897!

... to use those new versions supporting the new backend system.

Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
... by removing the events support, before fixing it later in upstream backstage.

Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
... for the embedded catalog providers.

Signed-off-by: David Festal <dfestal@redhat.com>
…nd system.

Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal davidfestal changed the title WIP: Proof PR of switching the Showcase to the new backend system Switching the Showcase to the new backend system & 1.23.0-next.3 pre-release Feb 15, 2024
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-897!

packages/app/package.json Outdated Show resolved Hide resolved
packages/backend/src/index.ts Outdated Show resolved Hide resolved
packages/backend/src/modules/rbacDynamicPluginsModule.ts Outdated Show resolved Hide resolved
davidfestal and others added 4 commits February 15, 2024 21:05
Co-authored-by: Paul Schultz <pschultz@pobox.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Co-authored-by: Paul Schultz <pschultz@pobox.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 15, 2024
Copy link

openshift-ci bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-897!

@openshift-merge-bot openshift-merge-bot bot merged commit 1f5f080 into janus-idp:main Feb 15, 2024
7 checks passed
kadel pushed a commit to kadel/backstage-showcase that referenced this pull request Feb 16, 2024
…release (janus-idp#897)

* Fix wrong names in `dynamic-plugins.default.yaml`

Signed-off-by: David Festal <dfestal@redhat.com>

* Move to 1.23.0-next.1

Signed-off-by: David Festal <dfestal@redhat.com>

* Switch to the new backend system

Signed-off-by: David Festal <dfestal@redhat.com>

* Update wrappers

Signed-off-by: David Festal <dfestal@redhat.com>

* Update the imported dynamic backend plugins ...

... to use those new versions supporting the new backend system.

Signed-off-by: David Festal <dfestal@redhat.com>

* Update configuration for `githubOrg` provider

Signed-off-by: David Festal <dfestal@redhat.com>

* Add changeset

Signed-off-by: David Festal <dfestal@redhat.com>

* Now use the new backend support added in the rbac plugin itself

Signed-off-by: David Festal <dfestal@redhat.com>

* Bump backstage version to 1.23.0-next.3

Signed-off-by: David Festal <dfestal@redhat.com>

* Include upstream fix for dynamic plugins config schemas

Signed-off-by: David Festal <dfestal@redhat.com>

* embed `@backstage/plugin-bitbucket-cloud-common` in the wrapper

Signed-off-by: David Festal <dfestal@redhat.com>

* Fix issue backstage/backstage#22932 in the wrapper...

... by removing the events support, before fixing it later in upstream backstage.

Signed-off-by: David Festal <dfestal@redhat.com>

* fix

Signed-off-by: David Festal <dfestal@redhat.com>

* Add the same schedule default as with the old backend...

... for the embedded catalog providers.

Signed-off-by: David Festal <dfestal@redhat.com>

* Add scaffolder actions which are not builtin anymore in the new backend system.

Signed-off-by: David Festal <dfestal@redhat.com>

* Update packages/backend/src/modules/rbacDynamicPluginsModule.ts

Co-authored-by: Paul Schultz <pschultz@pobox.com>

* Pin all dependencies

Signed-off-by: David Festal <dfestal@redhat.com>

* Update packages/backend/src/index.ts

Co-authored-by: Paul Schultz <pschultz@pobox.com>

* Add PR link

Signed-off-by: David Festal <dfestal@redhat.com>

---------

Signed-off-by: David Festal <dfestal@redhat.com>
Co-authored-by: Paul Schultz <pschultz@pobox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants