Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(changesets): remove changesets #939

Merged
merged 3 commits into from
Feb 20, 2024
Merged

chore(changesets): remove changesets #939

merged 3 commits into from
Feb 20, 2024

Conversation

schultzp2020
Copy link
Member

@schultzp2020 schultzp2020 commented Jan 30, 2024

Description

We should remove the changesets from the showcase because we have not updated the changelogs since dev preview.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Signed-off-by: Paul Schultz <pschultz@pobox.com>
@schultzp2020 schultzp2020 requested a review from a team as a code owner January 30, 2024 19:24
Copy link

changeset-bot bot commented Jan 30, 2024

⚠️ No Changeset found

Latest commit: 0f434f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-939!

@nickboldt
Copy link
Member

Not to be too pedantic, but you're not removing the changesets...

they're still in https://github.com/janus-idp/backstage-showcase/tree/main/.changeset

you're just no longer checking PRs for new ones, and removing the yarn commands to add new ones.

FWIW this may be a different path to what's suggested for migrated plugins from backstage-plugins -> community-plugins as that team likes changesets (but we might convince them to do releases on every commit using semantic release instead or in addition to changeset-grouped releases).

@kadel
Copy link
Member

kadel commented Jan 31, 2024

Wouldn't it be better if we start using this properly instead of removing it? Last release we had a hard time coming up with the changelog, if we start using changesets properly it will make releases easier.

@kadel
Copy link
Member

kadel commented Feb 19, 2024

@schultzp2020 can you please rebase?
/approve

@kadel
Copy link
Member

kadel commented Feb 20, 2024

Wouldn't it be better if we start using this properly instead of removing it? Last release we had a hard time coming up with the changelog, if we start using changesets properly it will make releases easier.

we discussed that and come to the conclusion that we will remove changes fro now

…into changesets

Signed-off-by: Paul Schultz <pschultz@pobox.com>
Signed-off-by: Paul Schultz <pschultz@pobox.com>
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-939!

Copy link

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel, nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@schultzp2020 schultzp2020 merged commit 6d146db into main Feb 20, 2024
7 checks passed
@schultzp2020 schultzp2020 deleted the changesets branch February 20, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants