-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(changesets): remove changesets #939
Conversation
Signed-off-by: Paul Schultz <pschultz@pobox.com>
|
The image is available at: |
Not to be too pedantic, but you're not removing the changesets... they're still in https://github.com/janus-idp/backstage-showcase/tree/main/.changeset you're just no longer checking PRs for new ones, and removing the yarn commands to add new ones. FWIW this may be a different path to what's suggested for migrated plugins from backstage-plugins -> community-plugins as that team likes changesets (but we might convince them to do releases on every commit using semantic release instead or in addition to changeset-grouped releases). |
Wouldn't it be better if we start using this properly instead of removing it? Last release we had a hard time coming up with the changelog, if we start using changesets properly it will make releases easier. |
@schultzp2020 can you please rebase? |
we discussed that and come to the conclusion that we will remove changes fro now |
…into changesets Signed-off-by: Paul Schultz <pschultz@pobox.com>
Signed-off-by: Paul Schultz <pschultz@pobox.com>
|
The image is available at: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel, nickboldt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
We should remove the changesets from the showcase because we have not updated the changelogs since dev preview.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer