Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update links on homepage #970

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

kim-tsao
Copy link
Member

Description

Update the links on the Janus homepage so they point to docs rather that actual deployment instances

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

locally tested and verified the links worked

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@kim-tsao kim-tsao requested a review from a team as a code owner February 15, 2024 15:30
Copy link

changeset-bot bot commented Feb 15, 2024

🦋 Changeset detected

Latest commit: f2e289c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Kim Tsao <ktsao@redhat.com>
Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-970!

Copy link

janus-idp bot commented Feb 15, 2024

backstage-showcase Tests on commit af6f16c finished with errors.
View test log

Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Zaperex
Copy link
Member

Zaperex commented Feb 16, 2024

/override "Showcase tests on OCP/PR Test"

Copy link

openshift-ci bot commented Feb 16, 2024

@Zaperex: Overrode contexts on behalf of Zaperex: Showcase tests on OCP/PR Test

In response to this:

/override "Showcase tests on OCP/PR Test"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d0c68b1 into janus-idp:main Feb 16, 2024
7 checks passed
kadel pushed a commit to kadel/backstage-showcase that referenced this pull request Feb 20, 2024
* update links on homepage

Signed-off-by: Kim Tsao <ktsao@redhat.com>

* Run yarn changeset:empty

Signed-off-by: Kim Tsao <ktsao@redhat.com>

---------

Signed-off-by: Kim Tsao <ktsao@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants