Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

fix: set route host properly when clusterRouterBase is set #166

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

Zaperex
Copy link
Member

@Zaperex Zaperex commented Jan 5, 2024

Description of the change

Set route host to the auto-generated value when clusterRouterBase is set.
The desired manifest for helm should now match the expected host
image

Additional Information

Now it doesn't actually get Openshift to auto-generate it. It instead utilizes the janus-idp.hostname value which matches the auto-generated value.

This will now require the clusterRouterBase to be properly configured or else the route host will be invalid and users will not be able to access the application via the Route.

Before this change, the route will still be valid if clusterRouterBase is misconfigured and users will still be able to the application, but the backstage config will be incorrect.

Existing or Associated Issue(s)

Fixes #136

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@Zaperex Zaperex requested a review from a team January 5, 2024 22:32
Copy link

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cf7aca4 into janus-idp:main Jan 24, 2024
4 checks passed
@Zaperex Zaperex deleted the fix-route branch January 24, 2024 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route defaults to host: null if global.clusterRouterBase is specified which makes it ArgoCD incompatible
2 participants