Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

docs: use upstream schema and recognize the dependency #50

Merged
merged 1 commit into from
May 9, 2023

Conversation

tumido
Copy link
Member

@tumido tumido commented May 4, 2023

Description of the change

  1. Reference remote schema introduced to the upstream chart. This makes our chart fully covered by JSON schema.
  2. Provide a notice/disclaimer that this chart is OpenShift specific.

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

README.md Outdated Show resolved Hide resolved
charts/backstage/README.md Outdated Show resolved Hide resolved
charts/backstage/README.md.gotmpl Outdated Show resolved Hide resolved
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tumido tumido merged commit a602115 into janus-idp:main May 9, 2023
2 checks passed
@tumido tumido deleted the update-schema branch May 9, 2023 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants