Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

feat: further simplify the config for autogenerated Route host in OCP #63

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

tumido
Copy link
Member

@tumido tumido commented Jun 2, 2023

Description of the change

In the current setup, the user needs to modify the default values to get proper backend-frontend routing. Let's simplify this for users using OCP router that can autogenerate hostname. This way the user needs to change/specify the `apps.

Existing or Associated Issue(s)

Resolves: #72

Additional Information

As a result, if user uses the default OpenShift autogenerated route host they can now use following values:

Old

upstream:
  backstage:
    appConfig:
      app:
        baseUrl: 'https://{{- print .Release.Name "-" .Release.Namespace -}}.apps.example.com'
      backend:
        baseUrl: 'https://{{- print .Release.Name "-" .Release.Namespace -}}.apps.example.com'
        cors:
          origin: 'https://{{- print .Release.Name "-" .Release.Namespace -}}.apps.example.com'

New

global:
  clusterRouterBase: apps.example.com

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@tumido tumido requested a review from sabre1041 June 2, 2023 10:08
@tumido
Copy link
Member Author

tumido commented Jun 2, 2023

CI is failing because of janus-idp/backstage-showcase#287

Copy link
Contributor

@schwesig schwesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
side note: I am fine with the naming.

Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
@tumido tumido merged commit 6117449 into janus-idp:main Jun 20, 2023
2 checks passed
@tumido tumido deleted the simplify-routes branch June 20, 2023 11:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify default values that are necessary to be configured when deploying to OpenShift
2 participants