Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community.mdx #33

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

schwesig
Copy link
Contributor

What does this PR do / why we need it

Which issue(s) does this PR fix

Fixes #23

PR acceptance criteria

  • Unit Tests
  • E2E Tests
  • Documentation

How to test changes / Special notes to the reviewer

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@schwesig schwesig force-pushed the Add-the-Youtube-Channel-link-#23 branch from a54fce7 to 39cfde5 Compare February 28, 2023 22:33
packages/ui/components/footer/footer.tsx Outdated Show resolved Hide resolved
packages/ui/components/footer/footer.tsx Outdated Show resolved Hide resolved
href: '/'
},
{
name: 'YouTube',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this link to the header as well?
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we do that in another pr since its a little bit more difficult than adding a key value pair in theme.config.js. We should also fix the lingering slack invites blog pages. I can work on adding them later today.

@serenamarie125
Copy link
Contributor

@schwesig, any chance you can get to this by the end of the week?

Copy link
Contributor

@christophe-f christophe-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophe-f christophe-f requested a review from tumido March 9, 2023 16:46
schultzp2020 and others added 2 commits March 9, 2023 15:20
Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com>
Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com>
@schultzp2020
Copy link
Member

schultzp2020 commented Mar 9, 2023

@tumido PTAL

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tumido tumido merged commit 04d981d into janus-idp:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the Youtube Channel link
5 participants