-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating slack links for issue #44 #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kclibrarian thanks for your PR! Just verified that https://join.slack.com/t/janus-idp/shared_invite/zt-1pxtehxom-fCFtF9rRe3vFqUiFFeAkmg is the proper link which does not expire! We had a previous PR which updated the link in the header, but not the footer. Please update and we will merg!
@@ -20,7 +20,7 @@ export function CommunityHeader() { | |||
|
|||
## Join the community | |||
|
|||
Start by joining our community. We have a [janus-idp](https://join.slack.com/t/janus-idp/shared_invite/zt-1pxtehxom-fCFtF9rRe3vFqUiFFeAkmg) Slack workspace that you can join and meet other Janus users. In all our communications, on whatever platform, we expect everyone to follow a code of contact. | |||
Start by joining our community. We have a [janus-idp](https://janus-idp.slack.com/archives/C04EDTPJRK5) Slack workspace that you can join and meet other Janus users. In all our communications, on whatever platform, we expect everyone to follow a code of contact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
@@ -67,7 +67,7 @@ const navigation = { | |||
}, | |||
{ | |||
name: 'Slack', | |||
href: 'https://join.slack.com/t/janus-idp/shared_invite/zt-1nii16o6e-SGscZ4YtAktL6rRtZZBUfA', | |||
href: 'https://janus-idp.slack.com/archives/C04EDTPJRK5', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this PR do / why we need it
The slack links were outdated in the header and footer and need to link to current, persistent link.
Which issue(s) does this PR fix
44: 2 slack links are expired.
Fixes #?
Updated links to new link.
PR acceptance criteria
How to test changes / Special notes to the reviewer