Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go mod tidy to make nightly happy #288

Merged
merged 1 commit into from Apr 2, 2024

Conversation

gazarenkov
Copy link
Collaborator

to fix:
/home/runner/work/operator/operator/bin/ginkgo --randomize-all --poll-progress-after=120s --poll-progress-interval=120s -timeout 14400s --no-color -nodes=1 tests/e2e
Failed to compile e2e:

go: updates to go.mod needed; to update it:
go mod tidy

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@openshift-ci openshift-ci bot added the lgtm PR is ready to be merged. Required by Prow. label Apr 2, 2024
Copy link

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 496da58 into janus-idp:main Apr 2, 2024
9 checks passed
@rm3l
Copy link
Member

rm3l commented Apr 2, 2024

Thanks. FYI, now that this is merged, I've just triggered a manual run of the Nightly Workflow: https://github.com/janus-idp/operator/actions/runs/8519266127

@rm3l
Copy link
Member

rm3l commented Apr 2, 2024

Thanks. FYI, now that this is merged, I've just triggered a manual run of the Nightly Workflow: janus-idp/operator/actions/runs/8519266127

🤔 Surprisingly, it does not seem to fix the nightly job: https://github.com/janus-idp/operator/actions/runs/8519266127/job/23332951137

@gazarenkov gazarenkov deleted the upstream_main branch April 19, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants