-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify about dynamic plugin's file name constraints. #381
Notify about dynamic plugin's file name constraints. #381
Conversation
…s.yaml" Signed-off-by: gazarenkov <gazarenkov@gmail.com>
…s.yaml" Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Quality Gate passedIssues Measures |
Previous cherry-pick comment edited by @rm3l to prevent the automated cherry-pick PR from being created. This will need to be cherry-picked later into the next patch release planned (1.2.1). |
@gazarenkov: once the present PR merges, I will cherry-pick it on top of 1.2.x in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this will need to be cherry-picked later into the next patch release planned (1.2.1).
So we will cherry-pick this later into the 1.2.x
branch right after the 1.2.0 release of RHDH is out.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
The problem is that dynamic plugins are silently not loaded in a case if the configured filename (key) in the configMap is not "dynamic-plugins.yaml" (as required by dynamic-plugins initContainer)
This PR makes deployment fail with error message in log.
For further improvement it:
Which issue(s) does this PR fix or relate to
https://issues.redhat.com/browse/RHIDP-1740
PR acceptance criteria