Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify about dynamic plugin's file name constraints. #381

Merged

Conversation

gazarenkov
Copy link
Member

Description

The problem is that dynamic plugins are silently not loaded in a case if the configured filename (key) in the configMap is not "dynamic-plugins.yaml" (as required by dynamic-plugins initContainer)
This PR makes deployment fail with error message in log.
For further improvement it:

Which issue(s) does this PR fix or relate to

https://issues.redhat.com/browse/RHIDP-1740

PR acceptance criteria

  • Tests

Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@gazarenkov
Copy link
Member Author

gazarenkov commented Jun 5, 2024

Previous cherry-pick comment edited by @rm3l to prevent the automated cherry-pick PR from being created.

This will need to be cherry-picked later into the next patch release planned (1.2.1).
So we will cherry-pick this later into the 1.2.x branch right after the 1.2.0 release of RHDH is out.

@openshift-cherrypick-robot

@gazarenkov: once the present PR merges, I will cherry-pick it on top of 1.2.x in a new PR and assign it to you.

In response to this:

/cherry-pick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gazarenkov gazarenkov requested a review from rm3l June 5, 2024 11:49
@gazarenkov gazarenkov mentioned this pull request Jun 5, 2024
1 task
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this will need to be cherry-picked later into the next patch release planned (1.2.1).
So we will cherry-pick this later into the 1.2.x branch right after the 1.2.0 release of RHDH is out.

@openshift-ci openshift-ci bot added the lgtm PR is ready to be merged. Required by Prow. label Jun 5, 2024
Copy link

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jun 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0d3ded3 into janus-idp:main Jun 5, 2024
8 checks passed
@gazarenkov gazarenkov deleted the dynamic_plugins_file_name branch June 21, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants