-
Notifications
You must be signed in to change notification settings - Fork 14
Deployment configuration and v1alpha2 version #388
Conversation
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
# Conflicts: # bundle/manifests/backstage-operator.clusterserviceversion.yaml # config/manifests/bases/backstage-operator.clusterserviceversion.yaml # integration_tests/db_test.go # integration_tests/default-config_test.go # pkg/model/secretfiles_test.go
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: gazarenkov <gazarenkov@users.noreply.github.com>
|
# Conflicts: # bundle/manifests/backstage-operator.clusterserviceversion.yaml
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
…t_patch # Conflicts: # bundle/manifests/backstage-operator.clusterserviceversion.yaml
Co-authored-by: gazarenkov <gazarenkov@users.noreply.github.com>
|
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
# Conflicts: # go.sum
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Description
This PR includes new way to configure Backstage deployment, now (in contrary to raw config) it is possible to add the changes as a and valid "fragment" of appsv1.deployment object inside Backstage CR and those fields will be merged with default (+raw) configuration, like:
Also, since this addition causes changes in the API, new API version
v1alpha2
was added. So, as for Operator versions 0.3.x and 0.4.x (if we consider 3 months release cadency and 6 months API maintain) it will support as minimum both v1alpha1 and v1alpha2 (which become a storage version). After upgrading Operator to 0.3.x the following behaviour expected:NOTE: v1alpha2 is backward compatible with v1alpha1 w/o data conversion
Openshift NOTE: deployment.patch field won't show up in the "Form view" when creating a CR from the OCP Web. To be able to edit it with ODC use "YAML view".
Which issue(s) does this PR fix or relate to
#352
PR acceptance criteria
rhdh-operator.csv.yaml
file accordinglyHow to test changes / Special notes to the reviewer