Some simple changes, one more controversial one #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually like the idea of adding the css class, but "active" seems a bit too generic. |
|
"rip-active" works for me. I just want something I can hook into. :) On May 23, 2011, at 2:11 PM, janv wrote:
|
|
Then please modify the pull request and I'll happily merge it. |
|
Once you've accepted these, I've got a couple of other patches for you :) |
janv
added a commit
that referenced
this pull request
May 24, 2011
Adding CSS class "rip-active" to active form field and a small jQuery noConflict fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits in here are really straight-forward; they make it easier to include the rest_in_place into a large app. The added semicolons make sure that you can concatenate the JS with other JS files into a single download, and the switch from $ to jQuery makes it work in compatibility mode.
The third commit is a bit more interesting, however -- it's changes to the JS to add an "active" class to the containing element when the form is activated. That scratches an itch of mine so that I can style all of the in-place fields on my site.