Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert zipcode to city #1

Open
janvankampen opened this issue Mar 16, 2020 · 2 comments
Open

Convert zipcode to city #1

janvankampen opened this issue Mar 16, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@janvankampen
Copy link
Owner

Due to time pressure, I've never implemented a feature to convert zipcodes to a city. The city field already exists in the data structure on Request and Hero (LocationCity), but I fill it manually on review.

I want to use a free service, or a static list to convert and fill it.
@xvilo
Copy link
Contributor

xvilo commented Mar 19, 2020

Maybe it's nice to keep the postalcode, as this will pin someone down on a small scale. This could usefull in larger cities. We should either add this data directly from a source (google maps api) when submitting or run a cron that resolves this ever x minutes async.

This was referenced Mar 20, 2020
Open
Closed
Closed
ferrydeboer added a commit to ferrydeboer/heldnodig-site that referenced this issue Mar 21, 2020
@ferrydeboer
janvankampen#1 foundating for upcoming zipcode conversion.
1a6d2e9
ferrydeboer added a commit to ferrydeboer/heldnodig-site that referenced this issue Mar 21, 2020
@ferrydeboer
janvankampen#1 typename typo XD
5736df5
ferrydeboer added a commit to ferrydeboer/heldnodig-site that referenced this issue Mar 21, 2020
@ferrydeboer
janvankampen#1 fixed codestyle issues
a31117f
ferrydeboer added a commit to ferrydeboer/heldnodig-site that referenced this issue Mar 21, 2020
@ferrydeboer
janvankampen#1 sigh, missed one newline
83e4646
ferrydeboer added a commit to ferrydeboer/heldnodig-site that referenced this issue Mar 21, 2020
@ferrydeboer
janvankampen#1 still missed one check
0fd79f3
@ferrydeboer ferrydeboer added refactoring Code refactoring and improvements enhancement New feature or request and removed refactoring Code refactoring and improvements labels Mar 21, 2020
@xvilo
Copy link
Contributor

xvilo commented Mar 21, 2020

Poc with current master: https://github.com/janvankampen/heldnodig-site/pull/39/files

Either I can refactor based on @ferrydeboer's MR or he should refactor his, based on mine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xvilo @janvankampen @ferrydeboer