Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to avoid the rustc_version and semver build dependencies #35

Closed
briansmith opened this issue Aug 26, 2021 · 3 comments
Closed

Comments

@briansmith
Copy link
Contributor

Hi, I'd like to use cast.rs but I'd also like to minimize my dependency tree. I noticed that rustc_version seems to be used primarily to decide whether to support 128-bit types. But, 128-bit types have been in stable Rust for years. I think it would be a better trade-off to break compatibility with the ancient versions of Rust with a new version that eliminates this conditional check. I would be happy to submit a PR that does this if you agree this makes sense.

@japaric
Copy link
Owner

japaric commented Aug 28, 2021

Hi, I think that sounds reasonable. I'd be OK with doing a 0.3.0 release that drops the rustc-version build dep, removes the x128 Cargo feature and removes the MSRV policy text from the docs. Feel free to submit a PR that does any part of that and I'll follow up with a release. Thanks for bringing this up!

@briansmith
Copy link
Contributor Author

PR #37 fixes this.

@japaric
Copy link
Owner

japaric commented Sep 4, 2021

done in #37

@japaric japaric closed this as completed Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants