Breaking change: Enable 128-bit integer support by default; increase MSRV. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MSRV. Eliminate the need for a build script, and eliminate the rustc_version dependency, to make cast.rs a more lightweight dependency for users. Increase the MSRV to 1.46.0 to match quickcheck 1.0. Enable all the test cases for i128 and u128 according to the commented-out blocks. I left two lines of test cases commented out since the tests fail to compile for them. I documented the MSRV to be 1.46.0 because I found `cargo test` fails to build the dependencies with 1.26.0, and it looks like quickcheck 1.0 has 1.46.0 as its MSRV. I didn't upgrade the arbitrary dependency to 1.0 because some of the tests fail when I tried. I filed an issue about this.
briansmith
commented
Aug 30, 2021
| // https://github.com/BurntSushi/quickcheck/issues/162 | ||
| /*#[cfg(feature = "x128")] | ||
| // TODO uncomment this. | ||
| /* |
There was a problem hiding this comment.
The Arbitrary support for u128 and i128 seems to work, but I couldn't figure out how to enable these two lines, so I left them commented out.
i128 => f32, f64 ;
u128 => f32, f64 ;
|
Note in particular that |
|
Thanks! |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate the need for a build script, and eliminate the rustc_version dependency,
to make cast.rs a more lightweight dependency for users. Increase the MSRV to 1.46.0
to match quickcheck 1.0.
I documented the MSRV to be 1.46.0 because I found
cargo testfails to build thedependencies with 1.26.0, and it looks like arbitrary 1.0 has 1.46.0 as its MSRV.
I didn't upgrade the arbitrary dependency to 1.0 because some of the tests fail when
I tried.