update panic-semihosting to 0.3.0 to use #[panic_implementation] #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tahnok. bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 22, 2018
94: update panic-semihosting to 0.3.0 to use #[panic_implementation] r=japaric a=tahnok Trying to use the `f3` crate with `rustc 1.28.0-nightly (b68432d56 2018-06-12)` fails to compile with ``` | 67 | #[lang = "panic_fmt"] | ^^^^^^^^^^^^^^^^^^^^^ definition of unknown language item `panic_fmt` error: aborting due to previous error ``` Following the recommendation in https://users.rust-lang.org/t/psa-breaking-change-panic-fmt-language-item-removed-in-favor-of-panic-implementation/17875 I bumped `panic-semihosting` to 0.3.0 Co-authored-by: Wesley Ellis <tahnok@gmail.com>
Build failed |
to workaround a rustup manifest problem
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 22, 2018
94: update panic-semihosting to 0.3.0 to use #[panic_implementation] r=japaric a=tahnok Trying to use the `f3` crate with `rustc 1.28.0-nightly (b68432d56 2018-06-12)` fails to compile with ``` | 67 | #[lang = "panic_fmt"] | ^^^^^^^^^^^^^^^^^^^^^ definition of unknown language item `panic_fmt` error: aborting due to previous error ``` Following the recommendation in https://users.rust-lang.org/t/psa-breaking-change-panic-fmt-language-item-removed-in-favor-of-panic-implementation/17875 I bumped `panic-semihosting` to 0.3.0 Co-authored-by: Wesley Ellis <tahnok@gmail.com> Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use the
f3crate withrustc 1.28.0-nightly (b68432d56 2018-06-12)fails to compile withFollowing the recommendation in https://users.rust-lang.org/t/psa-breaking-change-panic-fmt-language-item-removed-in-favor-of-panic-implementation/17875 I bumped
panic-semihostingto 0.3.0