Vec - PartialEq where Rhs is the Vec #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I also add a Changelog entry because I see that the CI is failing? |
the changelog being missing is not a showstopper -- the CI check can be skipped. if you can update the changelog in this PR, that'd be great |
|
bors merge |
|
Build succeeded: |
japaric
added a commit
that referenced
this pull request
Aug 9, 2022
|
v0.7.16 has been published and includes these changes |
mutantbob
pushed a commit
to mutantbob/heapless
that referenced
this pull request
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using the Vec for tests and initially, I was confused because I saw the impl for PartialEq but then I realized that PartialEq with Rhs of Vec was not implemented.
These impls are not mandatory but might help other people when using Vec on Rhs.
PS: Amazing crate btw, thanks you for the awesome work!