Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ieee802154.rs: add CCA-Energy Detection #1

Merged
merged 1 commit into from Jul 1, 2020
Merged

ieee802154.rs: add CCA-Energy Detection #1

merged 1 commit into from Jul 1, 2020

Conversation

Lotterleben
Copy link

@Lotterleben Lotterleben commented Jun 29, 2020 •
edited

This PR implements the Energy Detection CCA mode for the nrf52840-hal. It also adds some more documentation to bits of the existing code that I didn't find obvious.

note that the default CCA is set to ED for easier testing; should be reverted before merging

WIP:

  • add ED scan; use output for cca threshold
  • don't use READY-START for CCA-ED | EDIT: duh; only needed for ED scan anyway
  • undo changes to send()
  • cleanup: reset default CCA,

@Lotterleben Lotterleben marked this pull request as draft June 29, 2020 14:19
japaric
japaric reviewed Jun 29, 2020
View reviewed changes
Copy link
Owner

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left my feedback so far but this PR should include the ED sample API for completeness

nrf52840-hal/src/ieee802154.rs Outdated Show resolved Hide resolved
nrf52840-hal/src/ieee802154.rs Outdated Show resolved Hide resolved
nrf52840-hal/src/ieee802154.rs Outdated Show resolved Hide resolved
nrf52840-hal/src/ieee802154.rs Show resolved Hide resolved
@Lotterleben Lotterleben marked this pull request as ready for review June 30, 2020 16:10
@Lotterleben
Copy link
Author

will squash after approval

japaric
japaric reviewed Jun 30, 2020
View reviewed changes
Copy link
Owner

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking good! I left some suggestions

nrf52840-hal/src/ieee802154.rs Outdated Show resolved Hide resolved
nrf52840-hal/src/ieee802154.rs Outdated Show resolved Hide resolved
nrf52840-hal/src/ieee802154.rs Show resolved Hide resolved
nrf52840-hal/src/ieee802154.rs Show resolved Hide resolved
nrf52840-hal/src/ieee802154.rs Outdated Show resolved Hide resolved
nrf52840-hal/src/ieee802154.rs Outdated Show resolved Hide resolved
nrf52840-hal/src/ieee802154.rs Outdated Show resolved Hide resolved
nrf52840-hal/src/ieee802154.rs Outdated Show resolved Hide resolved
nrf52840-hal/src/ieee802154.rs Outdated Show resolved Hide resolved
nrf52840-hal/src/ieee802154.rs Outdated Show resolved Hide resolved
japaric
japaric approved these changes Jul 1, 2020
View reviewed changes
Copy link
Owner

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@japaric japaric merged commit b57ba81 into japaric:radio Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japaric japaric japaric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Lotterleben @japaric