Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please document why version 0.1.1 is yanked #13

Open
jannic opened this issue Aug 2, 2023 · 2 comments · May be fixed by #14
Open

Please document why version 0.1.1 is yanked #13

jannic opened this issue Aug 2, 2023 · 2 comments · May be fixed by #14

Comments

@jannic
Copy link

jannic commented Aug 2, 2023

Version 0.1.1 is yanked on crates.io, but CHANGELOG.md doesn't mention a reason and still lists that version.
jannic added a commit to jannic-dev-forks/rp2040-pac that referenced this issue Aug 2, 2023
@jannic
Bump dependency on vcell to version 0.1.3
cfb0c4c 
The depenency used to be on version 0.1.0, but the pac doesn't actually
compile with that version:

```
error[E0599]: no method named `as_ptr` found for struct `vcell::VolatileCell` in the current scope
   --> src/generic.rs:101:23
    |
101 |         self.register.as_ptr()
    |                       ^^^^^^ method not found in `VolatileCell<<REG as RegisterSpec>::Ux>`
```

`as_ptr` was added in version 0.1.1 of vcell, but that version is marked
as yanked for unknown reasons. (japaric/vcell#13)

Version 0.1.2 would have been another option, but 0.1.3 contains a fix for
japaric/vcell#5 which looks important.
@jannic jannic mentioned this issue Aug 2, 2023
Merged
@pftbest
Copy link
Contributor

pftbest commented Aug 2, 2023

Version 0.1.1 removed the unused const-fn feature from Cargo.toml which technically is a breaking change. Version 0.1.2 added it back for backwards compatibility. I guess it was yanked so you don't accidentally break your code on a minor version update.

@jannic
Copy link
Author

jannic commented Aug 2, 2023

Ok, I understand. I think yanking isn't very useful in such a situation:

  • if you have an existing Cargo.lock pointing to 0.1.1, or a dependency =0.1.1 in your Cargo.toml, yanking doesn't help
  • if you have a normal dependency on version 0.1 or 0.1.0, you get 0.1.2 automatically once it is released, it's not necessary to yank 0.1.1.

Anyway, it doesn't matter now, as it's quite unlikely that somebody has a strict dependency on version 0.1.1. In fact the only reason I noticed this was because I wanted to find out what's the oldest usable version of vcell for rp2040-pac, read in the README that the required feature was added in 0.1.1, and manually added a strict dependency to that version.

jannic added a commit to jannic-dev-forks/vcell that referenced this issue Aug 2, 2023
@jannic
Mention in changelog that v0.1.1 was yanked
ad8fb33 
Closes japaric#13
@jannic jannic linked a pull request Aug 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mention in changelog that v0.1.1 was yanked jannic-dev-forks/vcell
2 participants
@jannic @pftbest