Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only compile core for targets with "max-atomic-width": 0 #25

Closed
japaric opened this issue Aug 2, 2016 · 1 comment · Fixed by #26
Closed

Only compile core for targets with "max-atomic-width": 0 #25

japaric opened this issue Aug 2, 2016 · 1 comment · Fixed by #26

Comments

@japaric
Copy link
Owner

japaric commented Aug 2, 2016

Because alloc and other crates on top of it depend on atomics.

Blocked on rust-lang/rust#35176 reaching nightly. After that lands, we can test this on Travis.
@japaric
Copy link
Owner Author

japaric commented Aug 2, 2016

Actually, we can also compile rustc_unicode for these targets.

japaric pushed a commit that referenced this issue Aug 5, 2016
support targets that don't support atomics
869c2e5 
i.e. whose specification contains `"max-atomic-width": 0`. For these
targets, Xargo only compiles the `core` and `rustc_unicode` crates as
the other crates depend on atomics (e.g. `alloc::Arc`).

closes #25
@japaric japaric mentioned this issue Aug 5, 2016
Merged
japaric pushed a commit that referenced this issue Aug 6, 2016
support targets that don't support atomics
5e8965c 
i.e. whose specification contains `"max-atomic-width": 0`. For these
targets, Xargo only compiles the `core` and `rustc_unicode` crates as
the other crates depend on atomics (e.g. `alloc::Arc`).

closes #25
Nils-TUD pushed a commit to Nils-TUD/xargo that referenced this issue Sep 4, 2019
@phil-opp
Use the official approach for building liballoc (japaric#25)
7358641 
This means that we don't have to compile core separately. We also don't need to set RUSTFLAGS for building the sysroot, which fixes an issue reported in rust-osdev@5a26976#r31742585.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support targets that don't support atomics japaric/xargo
1 participant
@japaric