Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo update, recent rustc fixes, allow custom targets with embedded "." #226

Closed
wants to merge 1 commit into from

Conversation

evq
Copy link

@evq evq commented Nov 3, 2018

This PR is related to the changes in rust-lang/cargo#6255, originally discussed in rust-lang/rust#55041 (comment)

It allows for building using custom targets specs that have an embedded . with xargo.

I also had to make a few changes to get xargo to compile under the latest stable / nightly.

@thejpster
Copy link
Contributor

If you haven't seen, @phil-opp has forked Xargo to make https://github.com/rust-osdev/cargo-xbuild. That seems to be supported currently, while Xargo is in maintenance mode.

@evq
Copy link
Author

evq commented Nov 17, 2018

@thejpster there seems to be incompatibility between the way that cargo xbuild sets TARGET and how cortex-m-rt expects it to be passed when using a json file target. cargo xbuild sets it to the full file path which breaks the prefix comparisons and thus linking with the bin files. I'm not sure if this is an issue that should be resolved in cortex-m-rt or cargo-xbuild.

edit: I see you ran into similar issues re - rust-embedded/cortex-m-rt#145

@RalfJung
Copy link
Collaborator

We have updated xargo for recent rustc separately and also just landed a cargo update, so I will close this PR.

Feel free to re-submit the part about embedded . -- but unfortunately the entire thing is just one commit so it is not clear which changes are relevant for that.

@RalfJung RalfJung closed this Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants