Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expr methods are confusing #17

Closed
japgolly opened this issue Jun 4, 2019 · 1 comment
Closed

Expr methods are confusing #17

japgolly opened this issue Jun 4, 2019 · 1 comment

Comments

@japgolly
Copy link
Owner

japgolly commented Jun 4, 2019

final def compile2      [A,B](mkExpr: (String,String) => String): CompileDsl2[A,B] =
final def compileExpr2  [A,B](mkExpr: (String,String) => String)(implicit lang: Language,   final def apply2[A,B](mkExpr: (String,String) => String, a: A, b: B)(implicit lang: Language, A:ExprParam[A], B:ExprParam[B]): Expr[Value] =
final def compileFnCall2[A,B](fnName: String): CompileDsl2[A,B] =
final def callFn2       [A,B](fnName: String, a: A, b: B)(implicit lang: Language, A:ExprParam[A], B:ExprParam[B]): Expr[Value] =

I long ago thought that helpers in different shapes would be useful but really it's just confusing. The mental cost of figuring out which method to call is greater than any effort saved specifying a single type param (or whatever). Simplify and be consistent!

japgolly added a commit that referenced this issue Apr 7, 2020
@japgolly japgolly closed this as completed Apr 7, 2020
@japgolly
Copy link
Owner Author

japgolly commented Apr 7, 2020

Closed via 67f84b1 / 5d2f530 / 5aece45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant