Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds on non-linux platforms; and add a couple of extra models while here #2

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

stixpjr
Copy link

@stixpjr stixpjr commented Mar 29, 2024

pkg-config may live outside of whatever the scons default PATH happens to be; and some platforms require explicit linking against gl, glu & glut.

Inherit PATH from the environment, require gl, glu & glut.
"Begging dog" is my own creation, this "swan" version I thought was one of the originals.
@jaqx0r
Copy link
Owner

jaqx0r commented Mar 29, 2024

Thanks! Looks like glut doesn't have a pkg-config config on the GitHub Ubuntu tho.

@stixpjr
Copy link
Author

stixpjr commented Mar 29, 2024

Indeed. That's… unfortunate. You'd think portability would be easier in the year 2024…
I'll see about making it optional. My first foray into scons… so far I've only dealt with make, cmake, autotrash…

@jaqx0r
Copy link
Owner

jaqx0r commented Mar 29, 2024 via email

@stixpjr
Copy link
Author

stixpjr commented Mar 29, 2024

I've never found any of the configuration frameworks particularly friendly or flexible.

Anyway, this is Python. Made glu + glut optional the dumb way.

1 similar comment
@stixpjr
Copy link
Author

stixpjr commented Mar 29, 2024

I've never found any of the configuration frameworks particularly friendly or flexible.

Anyway, this is Python. Made glu + glut optional the dumb way.

@jaqx0r
Copy link
Owner

jaqx0r commented Mar 30, 2024

Awesome, thanks!

@jaqx0r jaqx0r merged commit f7f99c4 into jaqx0r:main Mar 30, 2024
2 checks passed
@jaqx0r
Copy link
Owner

jaqx0r commented Apr 3, 2024

Turns out pkg-config works if you install libglut-dev on Debian nowadays. Gunna update the instructions and github CI config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants