Handle units containing 'degree' and 'per' correctly #56
Conversation
Pull Request Test Coverage Report for Build 55
💛 - Coveralls |
tests/test_compounds.py
Outdated
| def test_unit_handling_fractional(): | ||
| test_cases = { | ||
| 'pound per square inch': 'pounds per square inch', | ||
| 'pound-force per square inch': 'pound-forces per square inch', |
There was a problem hiding this comment.
This is a bad example, I think the real plural is something like "pounds-force per square inch"!
There was a problem hiding this comment.
No I think this is correct:
"pound-force (plural pound-forces)" from Wiktionary
I do agree though that at first sight this does not sound correct...
There was a problem hiding this comment.
Here's the Oxford English Dictionary:
None of the other 10 dictionaries I checked show a plural form at all.
Google Books has 66 results for "pounds force per inch".
But only two results for "pound forces per inch".
The plural form on Wiktionary was added when the en-noun template was simply added, without taking care of the special-case plural:
{{en-noun|head=[[pound]]-[[force]]}}
https://en.wiktionary.org/w/index.php?title=pound-force&diff=13830692&oldid=13487437
I've fixed Wiktionary.
There was a problem hiding this comment.
Metric is so much easier :)
There was a problem hiding this comment.
Alright, fixed pluralization of 'pound-force' (and 'pound-weight' I hope) too
tests/test_compounds.py
Outdated
| test_cases = { | ||
| # Heat transfer coefficient unit | ||
| 'watt per square meter degree celsius': 'watts per square meter degree celsius', | ||
| 'degree celsius per hour': 'degrees celsius per hour' |
There was a problem hiding this comment.
This needs #55 then to be merged into master to work.
No description provided.