-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ratelimit notices #18
Comments
I've put together a draft implementation that would allow one to set a rate limit on a connection in 95d201adc509. One would simply call Let me know what you think, and if that interface would be suitable. Original comment by: Jason R. Coombs |
When trying to run it, hit a few snags - not sure if it's me. (not a python guy yet). client.py - line 967 : should it be .count() not .Count() Finally, what I can't figure out is this traceback: File "./libs/irc/bot.py", line 259, in start Original comment by: Jason Kendall |
Thanks for the help in troubleshooting and for the pull request. I've accepted the pull request and taken the opportunity to also add a couple of tests to exercise the Throttler class (something I would normally have done early). I've released 8.2 with this feature. Please let me know if you encounter any other issues. Original comment by: Jason R. Coombs |
Fixed and released in 8.2 Original comment by: Jason R. Coombs |
Thanks Jason. No way I would have thought of that method. Good learning for me as well. Original comment by: Jason Kendall |
Given certain situations, it's possible for someone to force a bot to exit if too many notices are buffered.
I'm sure I could rate limit in my code, but a forced rate limit in the lib might also be warranted.
The text was updated successfully, but these errors were encountered: