Fix EncodingWarning and ResourceWarning.

jaraco · Jul 29, 2023 · dea1e9d · dea1e9d
1 parent 93eb6ca
commit dea1e9d
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/jaraco/services/paths.py b/jaraco/services/paths.py
@@ -21,8 +21,6 @@ def exe(self):
     args: List[str] = []
     "Additional args to pass to the exe when testing for its suitability"
 
-    DEV_NULL = open(os.path.devnull, 'r+')
-
     @classmethod
     def resolve(cls):
         """
@@ -53,7 +51,8 @@ def find_valid_roots(cls):
     def is_valid_root(cls, root):
         try:
             cmd = [os.path.join(root, cls.exe)] + cls.args
-            subprocess.check_call(cmd, stdout=cls.DEV_NULL)
+            with open(os.path.devnull, 'r+', encoding='utf-8') as null:
+                subprocess.check_call(cmd, stdout=null)
         except OSError:
             return False
         return True