Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is keyring/__init__.py logging.getLogger call required? #291

Closed
coreycb opened this issue Oct 26, 2017 · 2 comments
Closed

is keyring/__init__.py logging.getLogger call required? #291

coreycb opened this issue Oct 26, 2017 · 2 comments

Comments

@coreycb
Copy link

coreycb commented Oct 26, 2017

Is the call to logging.getLogger() in keyring/__init__.py required?

I ask because we are hitting a bug in Ubuntu Artful where this line of code seems to expose the issue. That line is not the root cause of the problem but it seems to expose the issue. I'd like to remove that line of code as a work-around until we can get the real fix, but would like your input on whether it's needed first.

Here's the bug I'm referring to: https://bugs.launchpad.net/ubuntu/+source/python-openstackclient/+bug/1722553

Thanks,
Corey

@jaraco
Copy link
Owner

jaraco commented Nov 13, 2017

I'm afraid I don't understand what you're asking.

Is the call to logging.getLogger() in keyring/__init__.py required?

It's not required any more than the call to import keyring is required. But if you take that call out, the tests fail because logger is no longer available to be used by other modules.

Looking a little closer, I can see that that name is only used in one place in core, so it makes sense to move it there. Still, I don't understand how the presence or absence of that behavior would affect the downstream issue.

But if it will help, let's do it.

@jaraco jaraco closed this as completed Nov 13, 2017
@coreycb
Copy link
Author

coreycb commented Nov 14, 2017

Thanks @jaraco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants