Drop support for EOL Python 2.7 - 3.4 #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
reviewed
Mar 19, 2019
| @@ -1,9 +1,7 @@ | |||
| dist: xenial | |||
| sudo: false | |||
There was a problem hiding this comment.
I prefer to run with sudo: false. Is that the default now? If so, I'd like to make that change in jaraco/skeleton.
There was a problem hiding this comment.
The sudo: false env is no longer available and the sudo keyword is fully deprecated:
Would you like me to remove this commit?
There was a problem hiding this comment.
Fine to leave it as submitted. Thanks for the reference.
jaraco
reviewed
Mar 19, 2019
| @@ -80,7 +80,7 @@ def set_password(self, service, username, password): | |||
| "service": service, | |||
| "username": username | |||
| } | |||
| label = "Password for '%s' on '%s'" % (username, service) | |||
| label = "Password for '{}' on '{}'".format(username, service) | |||
There was a problem hiding this comment.
I probably would have deferred these compatible changes for another time, as it's more about style than compatibility, but happy to accept with them.
jaraco
requested changes
Mar 19, 2019
Updated! |
jaraco
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383.
Python 3.4 went EOL yesterday (2019-03-16).