Update MacOS keychain backend to new APIs #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow. This is exciting. Thanks for working on it. At first blush, it looks like the tests are only failing due to linter nitpicks. I'll fix those up and see if we can get this merged. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the MacOS keychain backend to use the new
SecItemAdd,SecItemCopyMatching, andSecItemDeleteAPIs, using a pure Python implementation with ctypes. This should address issue #519, as well as opening the door for further MacOS fixes — although it still does not appear to be possible to use TouchID to access the keychain, but this seems to be a limitation in Keychain itself.