Add more type annotations #625

lovetox · 2023-03-27T21:05:21Z

Hi,

I tried to add more type annotations

The docs say priority must be defined and is a property and must return float or int, but in the base class it was a method returning None. I tried to make this more consistent across the backends to make type checkers happy.

keyring/backend.py

jaraco · 2023-05-22T01:23:56Z

I've rebased the changes on top of 687d2c5 (fixing the emergent black failure).

keyring/backend.py

lovetox · 2023-05-24T17:56:23Z

I remove the commit, so everything is ready from my side

lovetox force-pushed the master branch 3 times, most recently from 86f0e23 to 3bd9a74 Compare March 27, 2023 22:30

jaraco reviewed May 22, 2023

View reviewed changes

keyring/backend.py Show resolved Hide resolved

jaraco force-pushed the master branch from 3bd9a74 to d356566 Compare May 22, 2023 01:22

jaraco reviewed May 22, 2023

View reviewed changes

keyring/backend.py Outdated Show resolved Hide resolved

lovetox added 2 commits May 21, 2023 21:39

Add type annotations for core.py

8035548

Add type annotations for backend.py

9641b81

jaraco force-pushed the master branch from ce24c0b to abb9d15 Compare May 22, 2023 01:39

lovetox and others added 2 commits May 24, 2023 19:46

Make defining priority property more consistent

c01a794

⚫ Fade to black.

4582e76

lovetox force-pushed the master branch from abb9d15 to 4582e76 Compare May 24, 2023 17:46

jaraco merged commit a94ff95 into jaraco:main May 24, 2023
16 checks passed

Provide feedback