Syntax error in py310compat.py

[pgergov]

Hello,

With the latest release https://github.com/jaraco/zipp/releases/tag/v3.16.0 there's a syntax error in py310compat.py file:

    def _text_encoding(encoding, stacklevel=2, /):
                                               ^
SyntaxError: invalid syntax

This is the commit that introduces the regression 4269d27

---

As a side note, dropping support for a version (in this case, Python 3.7) is considered a breaking change. When introducing breaking changes, you should increment the major version number, instead of the minor version.

[maartenbreddels]

https://pypi.org/project/zipp/3.16.0/ seems to list the requirement (python>=3.8) correctly, but we probably got this via conda/conda-forge.

[DamianBarabonkovQC]

I think someone has to patch the conda meta file to pin zipp if an old python is in use. I am unsure how to do that myself, but have seen it done.

[jaraco]

As a side note, dropping support for a version (in this case, Python 3.7) is considered a breaking change.

I used to share this opinion, but I've since decided that since the project is intentionally excluding support for the now broken version and declaring that support in the metadata, it's not actually a breaking change. That is, it's a normal course of development for versions to be added and removed. I follow this convention across the hundreds of projects I develop. If you think there's a compelling argument for always making a major bump when dropping support for EOL Pythons, you can make that case in jaraco/skeleton and present evidence/arguments that the best practice is to make a major bump. I do intend to follow best practices here and there's definitely room for dispute, but for now I've settled on a minor bump.

As you've all divined, this change was intentional, and the bug exists in conda (or other installers) not honoring the required Pythons directive.

[maartenbreddels]

Yeah, I agree this is not a zipp issue, but this should be fixed in the conda-recipe.