Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.name of a Path at the root should return the name of the zipfile #9

Closed
jaraco opened this issue Jul 7, 2019 · 1 comment
Closed

.name of a Path at the root should return the name of the zipfile #9

jaraco opened this issue Jul 7, 2019 · 1 comment

Comments

@jaraco
Copy link
Owner

jaraco commented Jul 7, 2019

In this comment, I've encountered my first use-case where the relationship between zipp.Path and its underlying filename are relevant. Ideally, this relationship would be well-defined and have nice, consistent properties, such as when invoking .name on the root of a zipp.Path.

On the other hand, it's not obvious to me what the value of Path(zf, '').name should be when zf is a zipfile in memory (or otherwise .root.filename is None).
jaraco added a commit that referenced this issue Jul 7, 2019
@jaraco
Add test capturing new expectation that a name of a Path object at th…
036d1eb 
…e root should be the name of the zipfile. Ref #9
@jaraco
Copy link
Owner Author

jaraco commented Jul 7, 2019

In the feature/root-name branch, I've drafted a patch, but I'm not sure I like it.

@jaraco jaraco mentioned this issue Jul 13, 2019
Closed
@jaraco jaraco closed this as completed in b1ff903 Oct 3, 2020
This was referenced Mar 15, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow .name on root Path object jaraco/zipp
1 participant
@jaraco