refactor code to support more use cases; added wrapper to converted c… #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode to better support special variables (require, module, exports) such as jaredhanson#4
|
Great work! Just ran into deamdify not correctly handing files in the following format: ...which is demonstrated as fixed in your changes to |
|
Awesome, I had started on plugin support as well, but if you've got momentum I don't want to stop you. Please start a new branch for the plugins work. This will get merged, but I need to review first as many files have changed. |
This was referenced May 28, 2015
Merged
|
Looks good 👍 |
tbranyen
added a commit
that referenced
this pull request
May 28, 2015
refactor code to support more use cases; added wrapper to converted c…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ode to better support special variables (require, module, exports) such as #4
In a previous discussion in gitter we briefly discussed adding support for AMD plugins (#27). I had started work, but never got it working completely. After our discussion, I was no longer able to do a clean merge, so I started re-coding based upon the latest master. This PR is some refactoring that is a mid point between my partial plugin support and the current master. If this is accepted, then I can create another PR for the plugin support.