WIP: COMPONENT_NOT_FOUND should be INTERFACE_NOT_FOUND

jaredhanson · May 7, 2020 · b731a5a · b731a5a
1 parent 700fa33
commit b731a5a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/lib/container.js b/lib/container.js
@@ -185,7 +185,7 @@ Container.prototype.create = function(id, parent, ecomp, options) {
           // Reject with a more informative error message that indicates the
           // requiring component.  This assists the developer in finding and
           // fixing the cause of error.
-          reject(new ComponentNotFoundError("Unable to create component '" + id + "' required by '" + (parent && parent.id || 'unknown') + "'"));
+          reject(new ComponentNotFoundError("Unable to create component '" + id + "' required by '" + (parent && parent.id || 'unknown') + "'", id));
         } else if (err) {
           return reject(err);
         }
@@ -253,7 +253,7 @@ Container.prototype._loadComponent = function(id, cb) {
       return cb(null, spec);
     }
   }
-  return cb(new ComponentNotFoundError("Cannot find component '" + id + "'"));
+  return cb(new ComponentNotFoundError("Cannot find component '" + id + "'", id));
 }
 
 /**

diff --git a/lib/errors/componentnotfound.js b/lib/errors/componentnotfound.js
@@ -3,11 +3,12 @@
  *
  * @api public
  */
-function ComponentNotFoundError(message) {
+function ComponentNotFoundError(message, iface) {
   Error.call(this);
   Error.captureStackTrace(this, arguments.callee);
   this.message = message;
-  this.code = 'COMPONENT_NOT_FOUND';
+  this.code = 'IMPLEMENTATION_NOT_FOUND';
+  this.interface = iface;
 }
 
 /**

diff --git a/lib/resolvers/id.js b/lib/resolvers/id.js
@@ -17,6 +17,8 @@
  */
 module.exports = function() {
 
+  // TODO: Redo this to search the container for object Ids, and don't impose a naming constraint
+
   return function(id) {
     if (/^[\w\-\.\/]+$/.test(id)) {
       return id;