Merge pull request #28 from siacomuzzi/invalid_redirect_uri_error

return AuthorizationError (instead of Error) when redirect_uri was not specified
jaredhanson · Feb 15, 2017 · 763cca9 · 763cca9
2 parents a39f28a + ab1acbe
commit 763cca9
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/lib/response/fragment.js b/lib/response/fragment.js
@@ -1,5 +1,6 @@
 var url = require('url')
-  , qs = require('querystring');
+  , qs = require('querystring')
+  , AuthorizationError = require('oauth2orize').AuthorizationError;
 
 /**
 * Authorization Response parameters are encoded in the fragment added to the redirect_uri when 
@@ -15,5 +16,5 @@ exports = module.exports = function (txn, res, params) {
 
 
 exports.validate = function(txn) {
-  if (!txn.redirectURI) { throw new Error('Unable to issue redirect for OAuth 2.0 transaction'); }
+  if (!txn.redirectURI) { throw new AuthorizationError('Unable to issue redirect for OAuth 2.0 transaction', 'server_error'); }
 };
diff --git a/test/grant/codeIdToken.test.js b/test/grant/codeIdToken.test.js
@@ -671,6 +671,8 @@ describe('grant.codeIdToken', function() {
 
       it('should error', function() {
         expect(err).to.be.an.instanceOf(Error);
+        expect(err.constructor.name).to.equal('AuthorizationError');
+        expect(err.code).to.equal('server_error');
         expect(err.message).to.equal('Unable to issue redirect for OAuth 2.0 transaction');
       });
     });

diff --git a/test/grant/idToken.test.js b/test/grant/idToken.test.js
@@ -679,6 +679,8 @@ describe('grant.idToken', function() {
 
       it('should error', function() {
         expect(err).to.be.an.instanceOf(Error);
+        expect(err.constructor.name).to.equal('AuthorizationError');
+        expect(err.code).to.equal('server_error');
         expect(err.message).to.equal('Unable to issue redirect for OAuth 2.0 transaction');
       });
     });

diff --git a/test/grant/idTokenToken.test.js b/test/grant/idTokenToken.test.js
@@ -921,6 +921,8 @@ describe('grant.idTokenToken', function() {
 
       it('should error', function() {
         expect(err).to.be.an.instanceOf(Error);
+        expect(err.constructor.name).to.equal('AuthorizationError');
+        expect(err.code).to.equal('server_error');
         expect(err.message).to.equal('Unable to issue redirect for OAuth 2.0 transaction');
       });
     });