Fix for PR #102 #103
Merged
Fix for PR #102 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solve the warning deprecated message during authorization.
|
The tests are only failing for node 0.4. Is that important? |
Closed
|
Nice @duereg 👍 Do you think this line should also be changed to contain
Mind you, the latest API is |
|
Honestly I don't know. I made this PR so long ago I'm not sure the state of this module or the facebook API. Would be nice if @jaredhanson would either merge or close this. |
|
True. Well, I updated, and here's my 2c at #110. Crickets... ;-) |
|
Merged via #110. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is replacement PR for #102 that includes passing tests.