Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an example to prevent a warning about express #4

Merged
merged 1 commit into from Nov 7, 2013

Conversation

gologo13
Copy link
Contributor

I found the following warning when I started an example of this library.
I prevented this warning by this pull request.

$ node app
Warning: express.createServer() is deprecated, express
applications no longer inherit from http.Server,
             please use:

              var express = require("express");
              var app = express();

@tmcw
Copy link

tmcw commented Nov 7, 2013

@jaredhanson ping - this looks to be pretty straightforward and anyone npm install'ing the examples will install a recent version of express

jaredhanson added a commit that referenced this pull request Nov 7, 2013
Fix an example to prevent a warning about express
@jaredhanson jaredhanson merged commit ef930c1 into jaredhanson:master Nov 7, 2013
@jaredhanson
Copy link
Owner

Merged, thanks! Most of the examples were written in the Express 2.x days, so they suffer this particular deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants