Wrap error for informative messages.

jaredhanson · Apr 28, 2012 · daa4569 · daa4569
1 parent 1f899fa
commit daa4569
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/passport-meetup/strategy.js b/lib/passport-meetup/strategy.js
@@ -2,7 +2,8 @@
  * Module dependencies.
  */
 var util = require('util')
-  , OAuthStrategy = require('passport-oauth').OAuthStrategy;
+  , OAuthStrategy = require('passport-oauth').OAuthStrategy
+  , InternalOAuthError = require('passport-oauth').InternalOAuthError;
 
 
 /**
@@ -71,7 +72,7 @@ util.inherits(Strategy, OAuthStrategy);
  */
 Strategy.prototype.userProfile = function(token, tokenSecret, params, done) {
   this._oauth.get('https://api.meetup.com/2/members?member_id=self', token, tokenSecret, function (err, body, res) {
-    if (err) { return done(err); }
+    if (err) { return done(new InternalOAuthError('failed to fetch user profile', err)); }
 
     try {
       var json = JSON.parse(body);

diff --git a/test/strategy-test.js b/test/strategy-test.js
@@ -118,6 +118,9 @@ vows.describe('MeetupStrategy').addBatch({
       'should error' : function(err, req) {
         assert.isNotNull(err);
       },
+      'should wrap error in InternalOAuthError' : function(err, req) {
+        assert.equal(err.constructor.name, 'InternalOAuthError');
+      },
       'should not load profile' : function(err, profile) {
         assert.isUndefined(profile);
       },