Clarify error messages.

jaredhanson · Mar 30, 2016 · 49e9a18 · 49e9a18
1 parent c15eba3
commit 49e9a18
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/state/session.js b/lib/state/session.js
@@ -20,7 +20,7 @@ var uid = require('uid2');
  * @api public
  */
 function SessionStore(options) {
-  if (!options.key) { throw new TypeError('SessionStateStore requires a key'); }
+  if (!options.key) { throw new TypeError('Session-based state store requires a session key'); }
   this._key = options.key;
 }
 
@@ -36,7 +36,7 @@ function SessionStore(options) {
  * @api protected
  */
 SessionStore.prototype.store = function(req, callback) {
-  if (!req.session) { return callback(new Error('OAuth2Strategy requires session support when using state. Did you forget app.use(express.session(...))?')); }
+  if (!req.session) { return callback(new Error('OAuth 2.0 authentication requires session support when using state. Did you forget to use express-session middleware?')); }
 
   var key = this._key;
   var state = uid(24);
@@ -57,7 +57,7 @@ SessionStore.prototype.store = function(req, callback) {
  * @api protected
  */
 SessionStore.prototype.verify = function(req, providedState, callback) {
-  if (!req.session) { return callback(new Error('OAuth2Strategy requires session support when using state. Did you forget app.use(express.session(...))?')); }
+  if (!req.session) { return callback(new Error('OAuth 2.0 authentication requires session support when using state. Did you forget to use express-session middleware?')); }
 
   var key = this._key;
   if (!req.session[key]) {

diff --git a/test/oauth2.state.session.test.js b/test/oauth2.state.session.test.js
@@ -103,7 +103,7 @@ describe('OAuth2Strategy', function() {
 
         it('should error', function() {
           expect(err).to.be.an.instanceof(Error)
-          expect(err.message).to.equal('OAuth2Strategy requires session support when using state. Did you forget app.use(express.session(...))?');
+          expect(err.message).to.equal('OAuth 2.0 authentication requires session support when using state. Did you forget to use express-session middleware?');
         });
       }); // that errors due to lack of session support in app
 
@@ -343,7 +343,7 @@ describe('OAuth2Strategy', function() {
 
         it('should error', function() {
           expect(err).to.be.an.instanceof(Error)
-          expect(err.message).to.equal('OAuth2Strategy requires session support when using state. Did you forget app.use(express.session(...))?');
+          expect(err.message).to.equal('OAuth 2.0 authentication requires session support when using state. Did you forget to use express-session middleware?');
         });
       }); // that errors due to lack of session support in app