Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scopes defined both in strategy constructor and authenticate() #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support scopes defined both in strategy constructor and authenticate() #99

wants to merge 1 commit into from

Conversation

anabellaspinelli
Copy link

I'm adding this feature for cases in which strategy users want to have default scope set up in their Strategy constructor (maybe something like profile) and then customize other scopes based on user selection.

Right now, the scope that comes in the authenticate() options object overrides whatever was set up in the constructor.

Tested it in the following scenarios:

  • Scopes defined both in strategy constructor and authenticate options obj
  • Scopes defined only in strategy constructor
  • Scopes defined only in authenticate options obj
  • No scopes are defined

@coveralls
Copy link

coveralls commented May 3, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling b126181 on anabellaspinelli:add-scopes-instead-of-override into a948096 on jaredhanson:master.

@anabellaspinelli
Copy link
Author

@jaredhanson @tomhughes @Tug @natalan

Hello!

This change (or something like it) would be really helpful for me and (Typeform), the company I work for.

I noticed there are a lot of pending PRs. Is this the correct way to request a review?

Thank you!

@rwky
Copy link

rwky commented Jul 7, 2018

@anabellaspinelli if you make a PR against https://github.com/passport-next/passport-oauth2 is will get looked into.

@anabellaspinelli
Copy link
Author

Thank you @rwky I will!

Just out of curiosity, what's the purpose of the fork?

@rwky
Copy link

rwky commented Jul 7, 2018

One of the companies I work for uses several passport modules and maintained our own forks, since the upstream modules aren't maintained I decided to fork them publicly in an organization so even if I get hit by a bus they won't go unmaintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants