fix unit test, cleanup travis, update dependencies #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables people to use passport-openidconnect directly when
specific parameters are required instead of creating another passport
strategy. A additional parameter can be passed within the authenticate
method, e.g.
passport.authenticate('openidconnect', {connection: 'my-oidc'})...
bufferoverflow
changed the title
ercanucan
approved these changes
Feb 27, 2018
|
+1 |
|
@jaredhanson @sjudson Could you have a look at this? |
|
@jaredhanson @sjudson: Ping. It would be great to have this change in. |
|
I've switched to the openid-client and it works like a charm. This library here is not maintained, see other discussions on #44 . |
|
I'm in the process of overhauling the test suite, updating dependencies, and releasing a new version of this package. Given that the test suite has been overhauled, this PR is no longer applicable. Thanks, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this includes #60