Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passport-remember-me is not working with passport 0.5.2 #33

Open
gritschf opened this issue Feb 14, 2022 · 5 comments
Open

passport-remember-me is not working with passport 0.5.2 #33

gritschf opened this issue Feb 14, 2022 · 5 comments

Comments

@gritschf
Copy link

Hi.
I've updated to passport 0.5.2.
With this version passport-remember-me isn't working anymore.

TypeError: Cannot set properties of undefined (setting 'user')
    at [mydir]\node_modules\passport-remember-me\node_modules\passport\lib\passport\http\request.js:45:35
    at pass ([mydir]\node_modules\passport\lib\authenticator.js:274:43)
    at serialized ([mydir]\node_modules\passport\lib\authenticator.js:283:7)
    at UserSerializer.serializeUser ([mydir]\dist\auth\user.serializer.js:23:9)
    at [mydir]\node_modules\@nestjs\passport\dist\passport\passport.serializer.js:8:61
    at pass ([mydir]\node_modules\passport\lib\authenticator.js:291:9)
    at Authenticator.serializeUser ([mydir]\node_modules\passport\lib\authenticator.js:296:5)
    at IncomingMessage.req.login.req.logIn ([mydir]\node_modules\passport-remember-me\node_modules\passport\lib\passport\http\request.js:43:29)
    at [mydir]\node_modules\@nestjs\passport\dist\auth.guard.js:63:64
    at new Promise (<anonymous>)

I think it is because the dependency of this package is ~0.1.1

  "dependencies": {
    "pkginfo": "0.2.x",
    "passport": "~0.1.1"
  },

When i replace the passport dependency manually with the content of version 0.5.2 its working again:

grafik

@davidzwa
Copy link

Can confirm here that I ran into exactly the same issue.

@gritschf
Copy link
Author

@jaredhanson could you please take a look at this and release a new version? (same problem with version 0.5.3)

@bazineta
Copy link

@gritschf @davidzwa Take a look at #10. Yes, it's from 2015; yes, it still fixes the problem. No, I don't know why it's never been merged.

@atog
Copy link

atog commented Aug 5, 2022

Can confirm it is still a problem with passport 0.6.0 and yes #10 still fixes the problem.

atog added a commit to atog/passport-remember-me that referenced this issue Aug 5, 2022
@aikimcr
Copy link

aikimcr commented Oct 14, 2022

It looks very much like this is just not being maintained anymore. Rather than patch or fork, I'm just going to abandon this strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants