Don't set req._passport.sesison in initialize middleware.

jaredhanson · Sep 23, 2021 · 7f41957 · 7f41957
1 parent 6861724
commit 7f41957
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 25 deletions.
diff --git a/lib/middleware/initialize.js b/lib/middleware/initialize.js
@@ -58,11 +58,6 @@ module.exports = function initialize(passport) {
     req._passport = {};
     req._passport.instance = passport;
 
-    if (req.session && req.session[passport._key]) {
-      // load data from existing session
-      req._passport.session = req.session[passport._key];
-    }
-
     next();
   };
 };
diff --git a/test/middleware/initialize.test.js b/test/middleware/initialize.test.js
@@ -37,10 +37,6 @@ describe('middleware/initialize', function() {
       expect(request._passport.instance).to.be.an.instanceOf(Passport);
       expect(request._passport.instance).to.equal(passport);
     });
-
-    it('should not expose empty object as session storage on internal request property', function() {
-      expect(request._passport.session).to.be.undefined;
-    });
   });
 
   describe('handling a request with a new session', function() {
@@ -74,10 +70,6 @@ describe('middleware/initialize', function() {
       expect(request._passport.instance).to.be.an.instanceOf(Passport);
       expect(request._passport.instance).to.equal(passport);
     });
-
-    it('should not expose session storage on internal request property', function() {
-      expect(request._passport.session).to.be.undefined;
-    });
   });
 
   describe('handling a request with an existing session', function() {
@@ -115,12 +107,6 @@ describe('middleware/initialize', function() {
       expect(request._passport.instance).to.be.an.instanceOf(Passport);
       expect(request._passport.instance).to.equal(passport);
     });
-
-    it('should expose session storage on internal request property', function() {
-      expect(request._passport.session).to.be.an('object');
-      expect(Object.keys(request._passport.session)).to.have.length(1);
-      expect(request._passport.session.user).to.equal('123456');
-    });
   });
 
   describe('handling a request with an existing session using custom session key', function() {
@@ -159,12 +145,6 @@ describe('middleware/initialize', function() {
       expect(request._passport.instance).to.be.an.instanceOf(Passport);
       expect(request._passport.instance).to.equal(passport);
     });
-
-    it('should expose session storage on internal request property', function() {
-      expect(request._passport.session).to.be.an('object');
-      expect(Object.keys(request._passport.session)).to.have.length(1);
-      expect(request._passport.session.user).to.equal('123456');
-    });
   });
 
 });