You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The upcoming scales 1.0.0 release is introducing a generic number formatter to power the formatting functions within the package. These changes have also meant the deprecation of the digits argument in lieu of the new accuracy argument.
When running revdep checks for the upcoming release, I noticed that this change will break 6 of your tests in tests-formatters.R, for your functions like multiple.dollar() or multiple.comma(). Just wanted to give you a head up. The release should be out next week but your tests should pass again with a simple switch of arguments specified.
The text was updated successfully, but these errors were encountered:
I don't see any reason why it should break your functions since they simply import the scales function itself, but there might be subtle changes -- you can read our news.md for more info on the upcoming changes and just take a look at the new code.
The only semi-breaking change I know of in this version of formatters is that previous versions could be passed character strings because they were based on format(). This is no longer the case and all of the formatters now require numerics.
The upcoming
scales 1.0.0
release is introducing a generic number formatter to power the formatting functions within the package. These changes have also meant the deprecation of thedigits
argument in lieu of the newaccuracy
argument.When running revdep checks for the upcoming release, I noticed that this change will break 6 of your tests in tests-formatters.R, for your functions like
multiple.dollar()
ormultiple.comma()
. Just wanted to give you a head up. The release should be out next week but your tests should pass again with a simple switch of arguments specified.The text was updated successfully, but these errors were encountered: