Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scales 1.0.0 release to break 6 formatter tests #6

Open
dpseidel opened this issue Jul 28, 2018 · 2 comments
Open

scales 1.0.0 release to break 6 formatter tests #6

dpseidel opened this issue Jul 28, 2018 · 2 comments

Comments

@dpseidel
Copy link

The upcoming scales 1.0.0 release is introducing a generic number formatter to power the formatting functions within the package. These changes have also meant the deprecation of the digits argument in lieu of the new accuracy argument.

When running revdep checks for the upcoming release, I noticed that this change will break 6 of your tests in tests-formatters.R, for your functions like multiple.dollar() or multiple.comma(). Just wanted to give you a head up. The release should be out next week but your tests should pass again with a simple switch of arguments specified.

@jaredlander
Copy link
Owner

Thanks for the heads up. So should I change the actual functions too?

@dpseidel
Copy link
Author

dpseidel commented Jul 28, 2018

I don't see any reason why it should break your functions since they simply import the scales function itself, but there might be subtle changes -- you can read our news.md for more info on the upcoming changes and just take a look at the new code.

The only semi-breaking change I know of in this version of formatters is that previous versions could be passed character strings because they were based on format(). This is no longer the case and all of the formatters now require numerics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants