Bring in jchavarri's changes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out caret behaves differently for versions under 1.0.0. `^0.0.3` is just like specifying `0.0.3` The More You Know.
Not putting the correct location on the Pexp_ident expression (the component name), results in type errors on line 0. <div foo=bar /> div -> Pexp_ident, needs a correct location in order to have correct type errors
Needed for Merlin's jump to location and type info in editor.
* Minimal changes to compile with OCaml 4.07 * Add Travis testing for 4.07.0+rc1 * Add CircleCI testing for 4.07.0 * Add missing m4 dependency to CircleCI * Pin utop to its development repository 4.07 support has been merged into its master branch. * Add 4.07.0-specific variant formatting test Thank you @IwanKaramazow! * Use final 4.07.0 release in Travis CI * rebase on master * specific test for 4.07
* FIX: Refmt link typo in Readme * Update README.md
* Use updated Menhir in Circle CI * Update config.yml
* Update esy workflow on ci * Fix travis ci
fixes reasonml#2190 The `consolidateSeparator` function was recursing on `Whitespace` nodes, however `preOrderWalk` would already do that for us. Therefore, we were calling this costly function in a hot path many more times than necessary, effectively making it take exponential time (I think).
* Remove `build` constraints from Dune in opam files The opam repository wants this gone * Rtop too
… be pinned from esy resolutions (reasonml#2447)
* Support OCaml 4.09 * fix oprint for older versions
* 3.5.1 release * Bump version in package.ml * Allow rtop to be installed with newer ocamls * Bump rtop version
* Use stages and build matrix * Try converting everything to matrixes * Run everything in parallel * Fix typo in variable * Use 4.08.1 as it was previously
* Try fixing cache directory on azure * Other fix * Wrong syntax? * Try commenting failing step
…ing a callback (reasonml#2474) * Fix braces removal in JSX props when having a pipe-first call containing a callback Made with the precious help from @anmonteiro Closes reasonml#2471 * Add a test with another case where braces were removed
* Make prepublish script auto-generate opam files * more fixes * more fixes * more fixes
* split reason_toolchain in a few sub-modules * Remove menhir error messages * removed more menhir-related error management * refactor errors in semantic actions * REMOVE ME: some notes * move more error management code to Reason_errors * recovery annotations * add recovery tool * build recovery * WIP lexer -> declarative_lexer, remove state * rewrite lexer to isolate state * factor the deterministic parser out of reason_toolchain * implement support for POSTFIX * introduce reason-multi-parser * Switch on recovery * add TODO plan * oops, better to recover more than one token * fix invalid docstrings merging * fix DOCSTRING parsing * fishy printing * recovery is now optional * update TODO * attach errors for intf and impl * Implement slightly better error messages * Update reason.opam * handle EOF * Use Migrate_parsetree.Ast_404 instead of Ast_404 Modules are being namespaced, direct access is now deprecated and will be removed (at some unknown point in the future). * Reenable previous error messages (through Reason_parser_explain) * detect unclosed parentheses * TEMPORARY: tweak unclosed parenthesis error message Still broken, the analysis can be improved * TEMPORARY: disable JSX error messages on recovery Recovery generates empty closing tag * wip: distinguish recovery errors * insert extension nodes only in recovery mode * build with 4.02 * instrument reason-error message printer * raise fatal errors if not using Reason_config.recoverable * no need for lexer_report_error * fix reporting of errors * refactor version-dependent definitions * move error manipulation to reason_syntax_util * menhir-recover: hide warnings about recover.cost attribute on production * fix error reporting (pre 4.08) * update more tests * Abstract version-dependent compiler-libs definitions to ocaml_util.ml Fix build with all versions of OCaml * update tests * add fix dependency to esy * fix tests
* Modernize CI based on latest hello-reason CI * Update main azure pipelines config * add odoc as dev dep to build CI docs * More fixes for the release
* Fix printing of fragments inside JSX props * Also fix pathological case for optional labeled args * add changes in new lexer file
* Fix releases for multi-bin release configs * one more fix for JS * Speed up CI cache on windows and log problems * a fix * Speed up CI cache on windows and log problems
* Make reason-cli correctly installable * Fix trailing colon * fix pipelines-release
jaredly
added a commit
that referenced
this pull request
Nov 28, 2019
Back in the "async await" discussions in reason land, there were vigorous proponents of both the "let." and "let!", so I figure I might as well add them here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.