Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Backend - Modals repeat #83

Closed
jaredlyon opened this issue Oct 4, 2022 · 6 comments · Fixed by #97
Closed

Backend - Modals repeat #83

jaredlyon opened this issue Oct 4, 2022 · 6 comments · Fixed by #97
Assignees
@jaredlyon
Labels
backend Data/scripting issue bug Something isn't working

Comments

@jaredlyon
Copy link
Owner

jaredlyon commented Oct 4, 2022 •
edited

Modals appear to repeat their .send functions

No idea why this is:
Screen Shot 2022-10-04 at 4 29 53 PM
@jaredlyon jaredlyon self-assigned this Oct 4, 2022
@jaredlyon jaredlyon added bug Something isn't working backend Data/scripting issue labels Oct 4, 2022
@jaredlyon jaredlyon mentioned this issue Oct 4, 2022
Merged
@jaredlyon
Copy link
Owner Author

Screen Shot 2022-10-04 at 6 25 31 PM

@jaredlyon
Copy link
Owner Author

The problem is that users can 'cancel' out of the modal, which leaves a residual instance that gets sent alongside the real one when they do submit.

@jaredlyon jaredlyon mentioned this issue Oct 14, 2022
Closed
jaredlyon added a commit that referenced this issue Oct 19, 2022
@jaredlyon
#83
1f85443
@jaredlyon
Copy link
Owner Author

Fixed in 1f85443.

@jaredlyon jaredlyon mentioned this issue Oct 19, 2022
Merged
@jaredlyon
Copy link
Owner Author

The issue has been fixed but has broken a few things down the line:
Screen Shot 2022-10-19 at 4 32 40 PM

The main issue is that the subsequent accept and reject buttons that are attached to the appeal do not send their confirmation messages back into the moderator channel, but the result is still DMed to the user.

@jaredlyon jaredlyon reopened this Oct 19, 2022
jaredlyon added a commit that referenced this issue Oct 19, 2022
@jaredlyon
#83 add catch
6f3c5d5
@jaredlyon jaredlyon mentioned this issue Oct 20, 2022
Closed
@jaredlyon
Copy link
Owner Author

The 'undefined' issue also persists:
Screen Shot 2022-10-26 at 4 01 28 PM

See #93

jaredlyon added a commit that referenced this issue Nov 18, 2022
@jaredlyon
#83 #93 #54
2c1df27
@jaredlyon
Copy link
Owner Author

Fixed in 2c1df27.

jaredlyon added a commit that referenced this issue Nov 18, 2022
@jaredlyon
Merge branch 'develop' into #83-fix-modals-repeat
17e330e
jaredlyon added a commit that referenced this issue Nov 18, 2022
@jaredlyon
Merge pull request #97 from jaredlyon/#83-fix-modals-repeat
e13d429 
#83 - Fix modals repeat
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jaredlyon jaredlyon

Labels
backend Data/scripting issue bug Something isn't working
Projects
Politibot Project Board 🚀
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#83 - Fix modals repeat jaredlyon/Operation-Politibot
1 participant
@jaredlyon